docs fix: correct weightCol for percentage change aggregations in DataTable docs#3268
Closed
wrathagom wants to merge 5 commits into
Closed
docs fix: correct weightCol for percentage change aggregations in DataTable docs#3268wrathagom wants to merge 5 commits into
wrathagom wants to merge 5 commits into
Conversation
wrathagom
had a problem deploying
to
Approval required to run action on external PR
February 5, 2026 23:21 — with 
GitHub Actions
Failure
GitHub Actions
Failure
wrathagom
had a problem deploying
to
Approval required to run action on external PR
February 9, 2026 19:19 — with
GitHub Actions
Failure
GitHub Actions
Failure
…e docs - Update example-project total-rows page to use prev_* columns as weightCol for percentage change columns (sales_change_pct0, num_orders_change_pct0, aov_change_pct0) - Add tip in DataTable documentation explaining that weightCol should be the baseline/previous value when aggregating percentage changes Co-Authored-By: Caleb Keller <calebmkeller@gmail.com>
Co-Authored-By: Caleb Keller <calebmkeller@gmail.com>
- Rewrote RadarChart to follow the Sankey pattern with direct ECharts config - Renamed inner component to InnerRadarChart.svelte - Removed old Radar.svelte that used Chart wrapper (incompatible with radar coordinate system) - Fixed lint errors and formatting Co-Authored-By: Caleb Keller <calebmkeller@gmail.com>
- Moved from chart-testing to charts folder (alongside other chart docs) - Added 15+ examples demonstrating all RadarChart features: - Basic single series radar - Multi-series comparison (Team A vs Team B) - Three-way product comparison - Circle shape vs polygon - Custom max value for consistent scaling - Fill opacity (high vs low) - Line width customization - Markers with custom size - Data labels showing values - Custom colors (fillColor, lineColor) - Color palette for multi-series - Combined styling options - Chart height customization - Each example includes clear description of what the prop does Co-Authored-By: Caleb Keller <calebmkeller@gmail.com>
Co-Authored-By: Caleb Keller <calebmkeller@gmail.com>
wrathagom
had a problem deploying
to
Approval required to run action on external PR
February 9, 2026 19:53 — with
GitHub Actions
Failure
GitHub Actions
Failure
Author
|
Splitting into two separate PRs for cleaner review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
re: #2592
Fixes incorrect weightCol values in DataTable documentation examples for percentage change aggregations.
When using totalAgg=weightedMean for percentage change columns, the weightCol should reference the baseline/previous value column, not the current value. This is because percentage changes are calculated relative to the original value (e.g., (new - old) / old).
Changes:
Checklist